Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medusa non regression test #1052

Merged
merged 12 commits into from
Sep 20, 2023
Merged

Conversation

adejanovski
Copy link
Contributor

What this PR does:
Adds a scale up operation after the Medusa restore in the e2e tests.
This exhibits a bug in Medusa that is due to a regression.
This PR also allows to run the Medusa e2e test using a specific tag. It enables us to run this e2e test when working on changes in Medusa, and will be used in Medusa's CI (see this PR).

Which issue(s) this PR fixes:
Fixes #1037

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@adejanovski adejanovski requested a review from a team as a code owner September 15, 2023 13:42
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1052 (e613f8e) into main (2588923) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   57.31%   57.28%   -0.03%     
==========================================
  Files         100      100              
  Lines       10160    10160              
==========================================
- Hits         5823     5820       -3     
- Misses       3828     3830       +2     
- Partials      509      510       +1     
Files Changed Coverage Δ
pkg/medusa/reconcile.go 56.62% <ø> (ø)

... and 1 file with indirect coverage changes


// Scale the cluster to verify that the previous restore won't break the new pod
t.Log("Scaling the cluster to 3 nodes")
err = f.Get(ctx, kcKey, kc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: For future, if you wish to type less:

require.NoError(f.Get(ctx, kcKey, kc))

@adejanovski adejanovski force-pushed the add-medusa-non-regression-test branch from dd35f04 to 173204e Compare September 18, 2023 06:24
@adejanovski adejanovski force-pushed the add-medusa-non-regression-test branch from 2165ca6 to 8066fd8 Compare September 20, 2023 06:42
@adejanovski adejanovski force-pushed the add-medusa-non-regression-test branch from 07c9213 to 6154bc3 Compare September 20, 2023 09:01
@adejanovski adejanovski force-pushed the add-medusa-non-regression-test branch from 5676746 to e613f8e Compare September 20, 2023 10:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -1,12 +1,9 @@
apiVersion: v1
data:
client.crt_signed: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVkVENDQXQwQ0ZCeDJGdnNCYzlVbk00MFlFUjdTTkhFcXluRzFNQTBHQ1NxR1NJYjNEUUVCQ3dVQU1JR2oKTVFzd0NRWURWUVFHRXdKR1VqRU1NQW9HQTFVRUNBd0RTVVJHTVE0d0RBWURWUVFIREFWUVlYSnBjekVSTUE4RwpBMVVFQ2d3SVJHRjBZVk4wWVhneEZ6QVZCZ05WQkFzTURsTlRURlJsYzNSRGJIVnpkR1Z5TVIwd0d3WURWUVFECkRCUlRVMHhVWlhOMFEyeDFjM1JsY2xKdmIzUkRRVEVyTUNrR0NTcUdTSWIzRFFFSkFSWWNZV3hsZUM1a1pXcGgKYm05MmMydHBRR1JoZEdGemRHRjRMbU52YlRBZUZ3MHlNekE1TVRreE9UUXhNamxhRncwek16QTVNVFl4T1RReApNamxhTUVveEN6QUpCZ05WQkFZVEFrWlNNUkV3RHdZRFZRUUtEQWhFWVhSaFUzUmhlREVYTUJVR0ExVUVDd3dPClUxTk1WR1Z6ZEVOc2RYTjBaWEl4RHpBTkJnTlZCQU1NQm1Oc2FXVnVkRENDQWFJd0RRWUpLb1pJaHZjTkFRRUIKQlFBRGdnR1BBRENDQVlvQ2dnR0JMQ2FPVjlqMWNpN0llSXR5WWRiVk0yQk1DQ0FSc01WZ0RtL0EwQllRaThjTQo5VlVNMlNXSDdnT0JaS1BHMUlGQStYWlFNSThIVEE0eG1TdGt3bXpRcjVYNmZSeVJiSVNlQmkrdnRFaENoWkVGCmprSno0WXV2NzArR2VjYkw0ZklaekYxdnJSS0ttbVVmYXZUaWJMOFpsV2tVUk1vcjhOVC9xZFp2M2RsWDhIWTUKZE1aKzVxZDh0S0dXWHh6VWtBWk5kTFcrUVdvc3VGRHc5aWswVlVZWnZPUGVITlFYdDFCSndlMTZSczJBY3VWSApid3lvbkgzUlYrY3VudHpKTk1tQTZxdS8zWGxnQnFYVHc4RHNtRVdHM2hmS3YwVUxMR2RRdjVKYkswa1RLSzBjCndoVnZUUTVMTXZkK2o2THh6enBYKzRLcFJtcGFnRzRyTTJJV1JNeTJ6aDVSUWF4dlBjRHpqUExRZ1RkZGpLY2gKaEF4QjVYeEFjdVd5QXN3ZldsRGdienQ4WjNDdHhYMmoreEc1NStZbGIrWVZkU0kwVDlRL2pBSjBwRW05MVVjeQp5c2hyMHladzRtREFrWHZ1cEw5VHJOWTQyQ2hDMDFkQnU5UU1NRkF2MVYwZmVMZXZOZERQM2xVQmlmbHZJVCtuClViOU02dHlkSjlodS9jVUxYcS9sdXdJREFRQUJNQTBHQ1NxR1NJYjNEUUVCQ3dVQUE0SUJnUUI3aDJUeFBuanUKOG84RlQ4UWhmbkptZ0NwVTRtbGNOS1RCWDlWT1RWZ1F3Z3lFVEhacVVRN3FkcHNZencwMXU5cjFrWWI4UkdqYQprYTZJZnlWM2FhRy9ZMG9VMEVzU2ZDWTA4RmNUcjFuaFozYThkK1hSM0I5YmdEZmxIQ1hkY1I5SVI5Ulg1TmpKCit2ajlxNC9TcnJLVEJKS0V2YzVqK3lQU1YrcEY2eHZjMGdpUnNSanUxank3eGRZSlVQZjJkWnBndGN2ZCs5Z2sKQ2pEbGlUSWlhMDlFajZtY2JwWHFvTDlLamNMNU9oc3BhWHFlWERQemNDWUJBencyR0NZMHNtMGw3aUd5MzV2cQo3N2Nmb09TUjlmbCtHNXh4eFVDSDdaVUR4ZDN4NWU5Y0RhYTNXUHB5cVlPTjN5WmIxNGZrNWZ2VHpGNVRzRjFzCjBlUE80K2VmdWNHNlZIbDZweXREVCt6a2cyU2hxcGNveFJEdkdCYjBjUjNCN3gwWG1RZVpFUlBqaytDd2phWjAKTCtiZmNFbkJxS2VjOHlDQ2h5T0dUd1MvbGtrMUpNNWZiRVJrdHRDUVJ5cy9EWG1ROXlrSlFtQkVpMmtCNktaSgozR1ZiZXZCM1B3ZkdZK0tYMXF5UGhPNjNSRjBvc3dON3hPcFlURXpZa1VucmgrR3dmMG1LWkQ4PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
client.key: LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1JSUhBQUlCQURBTkJna3Foa2lHOXcwQkFRRUZBQVNDQnVvd2dnYm1BZ0VBQW9JQmdTd21qbGZZOVhJdXlIaUwKY21IVzFUTmdUQWdnRWJERllBNXZ3TkFXRUl2SERQVlZETmtsaCs0RGdXU2p4dFNCUVBsMlVEQ1BCMHdPTVprcgpaTUpzMEsrVituMGNrV3lFbmdZdnI3UklRb1dSQlk1Q2MrR0xyKzlQaG5uR3krSHlHY3hkYjYwU2lwcGxIMnIwCjRteS9HWlZwRkVUS0svRFUvNm5XYjkzWlYvQjJPWFRHZnVhbmZMU2hsbDhjMUpBR1RYUzF2a0ZxTExoUThQWXAKTkZWR0diemozaHpVRjdkUVNjSHRla2JOZ0hMbFIyOE1xSng5MFZmbkxwN2N5VFRKZ09xcnY5MTVZQWFsMDhQQQo3SmhGaHQ0WHlyOUZDeXhuVUwrU1d5dEpFeWl0SE1JVmIwME9TekwzZm8raThjODZWL3VDcVVacVdvQnVLek5pCkZrVE10czRlVVVHc2J6M0E4NHp5MElFM1hZeW5JWVFNUWVWOFFITGxzZ0xNSDFwUTRHODdmR2R3cmNWOW8vc1IKdWVmbUpXL21GWFVpTkUvVVA0d0NkS1JKdmRWSE1zcklhOU1tY09KZ3dKRjc3cVMvVTZ6V09OZ29RdE5YUWJ2VQpEREJRTDlWZEgzaTNyelhRejk1VkFZbjVieUUvcDFHL1RPcmNuU2ZZYnYzRkMxNnY1YnNDQXdFQUFRS0NBWUVHCnpnM2NKTHRoVlN4SlJzdWpTelFDM2xiMFhQdXRDeUdYaUFwU3Zadmc3TUNtdUVHcDN4clkzaDhkbVEvN3ovZVQKbTU5Q0pNRnVBUXEyL2lwaVp5MkdhcStOaExvMkIzNFRHN0Ftc1lrdDdMWWhBUEFRZFp4eE03T0Q1ZGFsNVhxcwpJTzM3WWVOaXZGbXFmVzBWY0NKQmdQZlg5SENhWER5OXBpaTBLOGJkOEFoQ0RlMTFuL1N5STBKa2pZZmJzbHBTCk5mTDBRbjVRWXdxemFPZ1dpVWxOUlFmYjJmclZJbmNEMWhaUWZ4QjF1bU5zdVNtWExvaWcxbEtTdDIvOFhBblUKZmRwbFhiSjRzelFycTlWeXV6dVdwNWE5TUdGR2kweFJ4bnZBRFNtQ3NvUkhBQ3VGT1R4YS95dy8xaTltV01QNApqdG9aUmdDQlpMTjl2eGZiNHNDQ1hBQUlmRVQ0b3ZBK3Iyd1MxYTBhOXdrVXFES0tBdi9LYnB0V0xnTFN5MjRTClpoU1p0VXNMdE9lazVGQ05aaUhncWIyRW1nTlJGTXB2bGVBY0RuZ1BvclhJZ0JWNUpCM2FtYXdjdnI0MWVsQlMKN0d4YXhQcHZyWUVaSk9uekZxVjFxSzZTOC9BNmk0NER3MUdla0p3WlJ6MS9zcEJhb3k5bGpkSXN5T1AvZEVpTgpBb0hCQjBmYVliSmFscEhMU2hsOHcwRGluTElpRTF2VElzb2s1ZGs2Z2ZWakFJU2JWdWNUWW51TGJ1MXIvaHBTCll0ZUR4d1d0aFZrMHc0dFhQKzZCNjA4RzYzR01BcG1nbldFcjMvUWhGeGdrSnRaVGYxMmJuT1NBVG9hSDUvL2gKTWhQbktITGE4YzJndEV6cHVaVlRuamYrS0lDb1d0YTJjRkN4ckVxQlUvem9ub08zRnZ0aEhjMUpFSVJLMy9HYQpxbzJMSjhUZTNCaUh6TVV2YU9QWHJnTGhvWE5PVjhTM1hzelh5ekF1bjU5ZkEvQVIrVDJNcTVtelZVYXVmSVo5CkFmT2E1UUtCd1FZUVo1NE1UbXZxM3JNT3BVbmZkNVR0NnRER1JWMnhsOThjQklkMkxNcTJJRktaWUVsYkp0THEKVXN3aVRPWko4U0JtUWtjc29rbVVmM3g5bk9ZNzMxTnJmeHpQUjdxaStqTUhXOXppV0o0U0ZyYzgzM1krZktkZgpCK3ZybElEb3RyN1VDellKSGJGTHJRS3VhWkI4VXpyYU0ySG5DQjJwZ1h6OUpvT0NWWitEdUlOaXBtamEwVnJFClJLSjEyT3VKYmtQajh5Z1A2MjZtWEUrVmpZbHJ6UkxYTUF1by80cGh4YzFKMVMvSGJ2REFvREN0Z25aMmhsYXUKRjg2QzJaY1pWQjhDZ2NFQ1pXcUJGdExybFNZanlBbWd0VDBmdHh5eDVGbXpySFhDVStFR25uMHIwWGpTZkJDTQpLLzd5emg3cHJUNEtHOFhaL1l0alJMMngwYTB3ZEUyNzVQRnhFWml6emwzbkRmRURydlFwQnAvM1REaUV4WWtPCmRNR3BsbXNxTnJPbDZKaitYZmFpK0RyNHZBdDhNYUlvZzJNWmIyWjVKd3M2SWNTbjRJbDUyOVd2UGNoSFB3cHkKWlhxemZlYXFsM2lBd3o3V0l0djU4ZlRYdHRub21ud0VZQnhrSjIvVVFRRGNxV3dvQ2o1OStGU3NGaG5FUHJhSwpUM2FQRFVrbDRKbEp5Q1BsQW9IQkJTYUoyOE80R0JFMWRnQktnNlE2ZlZSV3pWeWFMaXBaUkRjWDRiYU45TjhjCk5RdndyRjJ2YkJWNm5jZkVhUlVFcVBBeCt5SDk5V0VicHpGSndvTzMrN0tpRkdZNkZsdTNCd0NKRmVOcVFWZzcKMHdieEJnMnM4cnZVanAxWlZPUlQwMkZtNUU1NTJjemM5aG9OcjVycFZtTmVvUmtKMjZmTlE4d0FtbEpwUjBNcAp4TzVWU1ZvUjEzWThsWUJpN2l1Y2JDMkFxZFpic1crN21CeitTbW8xbEhzUlk5WDJ0aUsxVHRnWEtxM0puTkwvClBGa2pKbHNsWHhvZlBsZ0ZXRUU3SVFLQndRQ25LTUt0cDJLWTgwNDBLZURxbVp3UFVoSWpXK1NVTldQV2VXdVUKdTBDemtjaEN0MktPanZ1eEFMVUFiQVRodEpPZDBjbEs0UktKRUFZZnc5YmxvNEl6bjJRWmRQZDJrUXBNSldHVgo3S3ZkV0kyREdWelFqa3A4ZWJLSTFGTEU3TkxFSkRvcDFmMlhmYnlBWSt6OGVFREEzeGNUeWlFNU9adGQ0RWxvCkxLWm8xRWVvaXBWUnNIOWlsK2pXWEh2MlNEUVFaT2NZeXQ5djZnNWpNU3JCU3cvYjVJUTBYcGpsRXJhbE5mWmQKcWs5NGZtSThUc0NuNzlud3NmYW1xc2ltbFVJPQotLS0tLUVORCBQUklWQVRFIEtFWS0tLS0tCg==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with these weird keynames?

Copy link
Contributor

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get those keys renamed to ca.crt/tls.key/tls.crt at some point, if we wish to use default tools (both in Kubernetes as well as cert-manager).

@adejanovski
Copy link
Contributor Author

We need to get those keys renamed to ca.crt/tls.key/tls.crt at some point, if we wish to use default tools (both in Kubernetes as well as cert-manager).

We're flexible in k8ssandra-operator, you can specify which key holds the value. So we're compatible with any layout of secrets.

@adejanovski adejanovski merged commit 80b0fce into main Sep 20, 2023
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to scale the cassandra cluster up when Medusa is enabled.
2 participants